Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: Avoid multiple allocs when merging stable and unstable log #10684

Merged
merged 1 commit into from
Apr 30, 2019
Merged

raft: Avoid multiple allocs when merging stable and unstable log #10684

merged 1 commit into from
Apr 30, 2019

Conversation

nvanbenschoten
Copy link
Contributor

Appending to an empty slice twice could (and often did) result in
multiple allocations. This was wasteful. We can avoid this by performing
a single allocation with the correct size and copying into it.

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

@nvanbenschoten
raft: Avoid multiple allocs when merging stable and unstable log
b5593de 
Appending to an empty slice twice could (and often did) result in
multiple allocations. This was wasteful. We can avoid this by performing
a single allocation with the correct size and copying into it.
@nvanbenschoten
Copy link
Contributor Author

cc. @bdarnell

nvanbenschoten added a commit to nvanbenschoten/rafttoy that referenced this pull request Apr 26, 2019
@nvanbenschoten
Vendor in-progress etcd/raft optimizations
7d67b33 
etcd-io/etcd#10679
etcd-io/etcd#10680
etcd-io/etcd#10684
nvanbenschoten added a commit to nvanbenschoten/rafttoy that referenced this pull request Apr 26, 2019
@nvanbenschoten
Vendor in-progress etcd/raft optimizations
fbaecb6 
etcd-io/etcd#10679
etcd-io/etcd#10680
etcd-io/etcd#10684
bdarnell
bdarnell approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that the compiler can't figure this out.

@xiang90 xiang90 merged commit e3f3753 into etcd-io:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdarnell bdarnell bdarnell approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @bdarnell @xiang90